Skip to content

gh-124703: Set return code to 1 when aborting process from pdb #133013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2025
Merged

gh-124703: Set return code to 1 when aborting process from pdb #133013

merged 3 commits into from
Apr 26, 2025

Conversation

@gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Apr 26, 2025 •
edited by bedevere-app bot
Loading

As #124703 (comment) mentioned, it's probably better to set the return code to something other than 0 when we abort the process from pdb. Logically it makes more sense, and the behavior is closer to what was before.

@bedevere-app bedevere-app bot mentioned this pull request Apr 26, 2025
Closed
@gaogaotiantian gaogaotiantian merged commit 4f18916 into python:main Apr 26, 2025
43 checks passed
@gaogaotiantian gaogaotiantian deleted the pdb-return-code branch April 26, 2025 22:43
@graingert graingert mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaogaotiantian @iritkatriel